Support custom reference lines #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhf
force-pushed
the
feat/custom-ref-lines
branch
from
b3244f9
to
30e2dc7
Compare
abdelaz3r
reviewed
Mar 7, 2024
| @@ -41,7 +42,8 @@ defmodule SparklineSvg.MixProject do | |||
| [ | |||
| {:credo, "~> 1.7", only: [:dev, :test], runtime: false}, | |||
| {:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false}, | |||
| {:ex_doc, "~> 0.31", only: :dev, runtime: false} | |||
| {:ex_doc, "~> 0.31", only: :dev, runtime: false}, | |||
| {:mix_test_watch, "~> 1.0", only: :test, runtime: false} | |||
|
Thank you very much, this is a great contribution! As discussed on a different channel, I'll close that PR and open a new one with additionnal documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on a different channel here's a suggestion for custom reference lines. I also added tests with my use case for this feature, the implementation can serve as example for others but happy to make a simpler test case, maybe you'd rather have something like what I added to the refline documentation.